[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

[Derek Bruening via llvm-commits]

bruening added inline comments.

================
Comment at: lib/esan/esan_interface.h:14
@@ +13,3 @@
+// module.
+// This header can be included by the instrumented program or by esan tests.
+//===----------------------------------------------------------------------===//
----------------
aizatsky wrote:
> eugenis wrote:
> > If this is meant to be included by the instrumented program, it should go under include/sanitizer. And not use sanitizer_internal_defs.h.
> Maybe this should be esan_internal_interface.h? I don't suppose any functions here should be called manually.
Removing that comment line.  It was based on lib/tsan/tsan_interface.h (which should be in include/sanitizer?) but our only use is insertion via instrumentation.

================
Comment at: lib/esan/esan_interface.h:14
@@ +13,3 @@
+// module.
+// This header can be included by the instrumented program or by esan tests.
+//===----------------------------------------------------------------------===//
----------------
bruening wrote:
> aizatsky wrote:
> > eugenis wrote:
> > > If this is meant to be included by the instrumented program, it should go under include/sanitizer. And not use sanitizer_internal_defs.h.
> > Maybe this should be esan_internal_interface.h? I don't suppose any functions here should be called manually.
> Removing that comment line.  It was based on lib/tsan/tsan_interface.h (which should be in include/sanitizer?) but our only use is insertion via instrumentation.
Will rename to esan_interface_internal.h to mirror asan and msan.  Unfortunately that will likely make the prior comments not linked to the new file unless this review system is that advanced.


http://reviews.llvm.org/D19168