[PATCH] D19096: ModuleLinker: do not always pull-in linkonce_odr when performing ThinLTO importing

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 13:48:01 PDT 2016


rafael added inline comments.

================
Comment at: test/ThinLTO/X86/alias_resolution.ll:57
@@ +56,3 @@
+; FIXME: not sure why we would want an extern_weak here.
+; IMPORT-DAG:  @linkonceODRfuncWeakAlias = extern_weak alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
+
----------------
Are we still producing an extern_weak alias? This should be failing the verifier...


http://reviews.llvm.org/D19096





More information about the llvm-commits mailing list