[llvm] r266805 - [Orc] Add explicit move ops to OrcRemoteTargetRPCAPI for MSVC.

[David Blaikie via llvm-commits]

On Tue, Apr 19, 2016 at 12:35 PM, Lang Hames via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: lhames
> Date: Tue Apr 19 14:35:16 2016
> New Revision: 266805
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266805&view=rev
> Log:
> [Orc] Add explicit move ops to OrcRemoteTargetRPCAPI for MSVC.
>
> Modified:
>     llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h
>
> Modified:
> llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h?rev=266805&r1=266804&r2=266805&view=diff
>
> ==============================================================================
> --- llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h
> (original)
> +++ llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcRemoteTargetRPCAPI.h
> Tue Apr 19 14:35:16 2016
> @@ -85,6 +85,17 @@ protected:
>    };
>
>  public:
> +
> +  // FIXME: Remove constructors once MSVC supports synthesizing move-ops.
> +  OrcRemoteTargetRPCAPI() = default;
> +  OrcRemoteTargetRPCAPI(const OrcRemoteTargetRPCAPI&) = delete;
> +  OrcRemoteTargetRPCAPI& operator=(const OrcRemoteTargetRPCAPI&) = delete;
> +
> +  OrcRemoteTargetRPCAPI(OrcRemoteTargetRPCAPI&&) {}
> +  OrcRemoteTargetRPCAPI& operator=(OrcRemoteTargetRPCAPI&&) {
> +    return *this;
> +  }
>

This seems strange - if it has no state, it should be implicitly copyable &
that should be harmless, right? (& you could use the copy ctor from other
move ops freely/harmlessly)



> +
>    enum JITFuncId : uint32_t {
>      InvalidId = RPCFunctionIdTraits<JITFuncId>::InvalidId,
>      CallIntVoidId = RPCFunctionIdTraits<JITFuncId>::FirstValidId,
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160419/1c646052/attachment.html>