[PATCH] D19168: [esan] EfficiencySanitizer base runtime library

[Mike Aizatsky via llvm-commits]

aizatsky added inline comments.

================
Comment at: lib/esan/esan_interface.h:14
@@ +13,3 @@
+// module.
+// This header can be included by the instrumented program or by esan tests.
+//===----------------------------------------------------------------------===//
----------------
eugenis wrote:
> If this is meant to be included by the instrumented program, it should go under include/sanitizer. And not use sanitizer_internal_defs.h.
Maybe this should be esan_internal_interface.h? I don't suppose any functions here should be called manually.

================
Comment at: lib/esan/esan_interface.h:38
@@ +37,3 @@
+
+SANITIZER_INTERFACE_ATTRIBUTE void __esan_aligned_read1(void *Addr);
+SANITIZER_INTERFACE_ATTRIBUTE void __esan_aligned_read2(void *Addr);
----------------
Please add a general comment about this group of functions: when are they called (and when they are not). Comments on interface between instrumenter/runtime are really helpful.


http://reviews.llvm.org/D19168