[PATCH] D17740: [PPC, SSP] Support PowerPC Linux stack protection using LOAD_STACK_GUARD

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 19 12:54:02 PDT 2016


echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.

Hi Tim,

Other than one patch I'd like you to write first this just needs comments and you're good to go. Thanks a ton.

-eric


================
Comment at: lib/Target/PowerPC/PPCISelLowering.cpp:12017
@@ +12016,3 @@
+
+bool PPCTargetLowering::useLoadStackGuardNode() const {
+  if (!Subtarget.isTargetLinux()) {
----------------
Comment explaining why on all 3 of these functions please.

================
Comment at: lib/Target/PowerPC/PPCISelLowering.h:694
@@ +693,3 @@
+    void insertSSPDeclarations(Module &M) const override;
+    Value *getSDStackGuard(const Module &M) const override;
+
----------------
Mind going back in time and renaming this getSDagStackGuard please?

================
Comment at: lib/Target/PowerPC/PPCInstrInfo.cpp:1860
@@ -1859,1 +1859,3 @@
 
+bool PPCInstrInfo::expandPostRAPseudo(MachineBasicBlock::iterator MI) const {
+  switch (MI->getOpcode()) {
----------------
Comments.


http://reviews.llvm.org/D17740





More information about the llvm-commits mailing list