[PATCH] D17356: Fix PR26655: Bail out if all regs of an inst BUNDLE have the correct kill flag

[Mandeep Singh Grang via llvm-commits]

mgrang added a comment.

Sorry Tim for the delay in addressing your comments - was busy with an upcoming release.

So I ran the entire set of correctness tests in our validation framework without the check for isInternalRead() and I did not see any extra regressions. Also there are no extra unit test failures without this check. So I guess the check for isInternalRead() is really not   needed and can be safely removed.

On the other hand the check for isDebug() is needed otherwise the following unit test fails:

  ******************** TEST 'LLVM :: CodeGen/MIR/ARM/sched-it-debug-nodes.mir' FAILED ********************
  Script:
  --
  build/llvm/./bin/llc -mtriple thumbv7 -start-after if-converter -print-before=post-RA-sched -print-after=post-RA-sched src/llvm/test/CodeGen/MIR/ARM/sched-it-debug-nodes.mir -o /dev/null 2>&1 | build/llvm/./bin/FileCheck src/llvm/test/CodeGen/MIR/ARM/sched-it-debug-nodes.mir
  --
  Exit Code: 134
  
  Command Output (stderr):
  --
  build/llvm/test/CodeGen/MIR/ARM/Output/sched-it-debug-nodes.mir.script: line 1: 41373 Aborted                 build/llvm/./bin/llc -mtriple thumbv7 -start-after if-converter -print-before=post-RA-sched -print-after=post-RA-sched src/llvm/test/CodeGen/MIR/ARM/sched-it-debug-nodes.mir -o /dev/null 2>&1
       41374 Done                    | build/llvm/./bin/FileCheck src/llvm/test/CodeGen/MIR/ARM/sched-it-debug-nodes.mir


Repository:
  rL LLVM

http://reviews.llvm.org/D17356