[PATCH] D10640: [mips][microMIPS] Implement LWP and SWP instructions

[Simon Dardis via llvm-commits]

sdardis added a comment.

This patch looks mostly correct to me except it's missing a key issue, that for lwp rd and base cannot be the same. lwp is not guaranteed to be uninterruptible so an interrupt could render lwp not restartable if they are the same.

Fortunately we already have an similar example with jalr.hb. You need to extend MipsAsmParser::checkTargetMatchPredicate(MCInst &Inst) on line 3668 to account for this context sensitive predicate.


http://reviews.llvm.org/D10640