[PATCH] D19096: ModuleLinker: do not always pull-in linkonce_odr when performing ThinLTO importing

[Rafael Espíndola via llvm-commits]

On 19 April 2016 at 09:00, Rafael Ávila de Espíndola
<llvm-commits at lists.llvm.org> wrote:
> rafael added inline comments.
>
> ================
> Comment at: test/ThinLTO/X86/alias_resolution.ll:49
> @@ +48,3 @@
> +; IMPORT-DAG:  @linkonceODRfuncAlias = alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
> +; IMPORT-DAG:  @linkonceODRfuncWeakAlias = extern_weak alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
> +; IMPORT-DAG:  @linkonceODRfuncLinkonceAlias = linkonce alias void (...), bitcast (void ()* @linkonceODRfunc to void (...)*)
> ----------------
> Is this valid? I would expect extern_weak to be only for declarations and aliases are always definitions.


In fact the verifier rejects:

@g = weak global i32 0
@a = extern_weak alias i32, i32* @g

Cheers,
Rafael