[PATCH] D19167: [esan] EfficiencySanitizer instrumentation pass

[Derek Bruening via llvm-commits]

bruening marked 11 inline comments as done.

================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:21
@@ +20,3 @@
+
+#include "llvm/Transforms/Instrumentation.h"
+#include "llvm/ADT/SmallString.h"
----------------
pcc wrote:
> aizatsky wrote:
> > bruening wrote:
> > > aizatsky wrote:
> > > > wrong import order. Please run clang-tidy & clang-format on the file.
> > > Will do.  Note that AddressSanitizer.cpp, MemorySanitizer, ThreadSanitizer.cpp, etc. on which this file is based all have this same (incorrect) order.
> > Those files do not conform to LLVM coding style right now, but we'd like them to. There's no reason why new code shouldn't.
> No, see http://llvm.org/docs/CodingStandards.html#a-public-header-file-is-a-module third paragraph.
So the current code is correct.  Note that clang-format does not think so.


http://reviews.llvm.org/D19167