[PATCH] D18291: Add IntrOnlyWrite intrinsic property

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/comments addressed.


================
Comment at: include/llvm/IR/Intrinsics.td:46
@@ +45,3 @@
+
+// IntrWriteArgMem - This intrinsic writes only to memory that one of its
+// arguments points to, but may access an unspecified amount. The writes may
----------------
A better approach would be to split the existing ReadArgMem into an ArgMemOnly attribute and the existing ReadMemOnly attribute.  I will not require that for this change, but it would be a worthwhile cleanup.  

================
Comment at: include/llvm/IR/Intrinsics.td:48
@@ +47,3 @@
+// arguments points to, but may access an unspecified amount. The writes may
+// be volatile, but the intrinsic does not read from memory and has no other
+// side effects. This means that dead stores before calls to this intrinsics
----------------
The writes can not be volatile.  We model a volatile write as both reading and writing from the address.  Changing that would be a much larger change.


http://reviews.llvm.org/D18291