[PATCH] D18949: [AArch64] Cannonicalize commutative operands based on LSLFast

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 15:22:03 PDT 2016


t.p.northover added a comment.

> If they don't have a positive effect on vanilla AArch64 design, it should be behind a Feature flag.


I'm instantly suspicious of code behind any kind of CPU check. I'd say enable it generally unless there's good reason not to. It avoids code complication and overly-specific optimizations.

Tim.


Repository:
  rL LLVM

http://reviews.llvm.org/D18949





More information about the llvm-commits mailing list