[PATCH] D18679: Port demanded-bits to the new pass manager

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 14:27:46 PDT 2016


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!!


================
Comment at: include/llvm/Analysis/DemandedBits.h:73
@@ +72,3 @@
+private:
+  mutable Optional<DemandedBits> DB;
+public:
----------------
Wow. Yea, I'm fine with the mutable member, that makes perfect sense.

I think the "right" way to fix this is much the way the new pass manager does it -- have separate printing passes from analysis passes so that the printing passes can actually walk the lazy data structures.

Anyways, no need to try to clean this up for the old pass manager, this seems like a strict improvement over the prior state of the world.


http://reviews.llvm.org/D18679





More information about the llvm-commits mailing list