[PATCH] D19236: Add DITypeIndex for CodeView and emit it for locals

[Reid Kleckner via llvm-commits]

rnk added a comment.

In http://reviews.llvm.org/D19236#404416, @llvm-commits wrote:

> Maybe "ImmutableMetadata"?


I think the main property they share is that they have no metadata operands: they are leaves of the metadata graph. So, maybe LeafMetadata? MDLeaf? DILeaf?


================
Comment at: unittests/IR/MetadataTest.cpp:1407
@@ -1406,3 +1406,3 @@
   unsigned Line = 2;
-  DISubroutineType *Type = getSubroutineType();
+  DITypeRef Type = DITypeRef(getSubroutineType());
   bool IsLocalToUnit = false;
----------------
dblaikie wrote:
> X y = X(z); -> X y(z); perhaps?
> 
> and/or should DITypeRef be implicitly convertible from a DIType?
The primary TypedDINodeRef constructor is marked explicit, so I shied away from adding an implicit constructor. However, it is constructing from a generic Metadata*, and an implicit constructor from T* would be pretty safe.


http://reviews.llvm.org/D19236