[PATCH] D19236: Add DITypeIndex for CodeView and emit it for locals

David Blaikie via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 13:56:08 PDT 2016


dblaikie added inline comments.

================
Comment at: unittests/IR/MetadataTest.cpp:1407
@@ -1406,3 +1406,3 @@
   unsigned Line = 2;
-  DISubroutineType *Type = getSubroutineType();
+  DITypeRef Type = DITypeRef(getSubroutineType());
   bool IsLocalToUnit = false;
----------------
X y = X(z); -> X y(z); perhaps?

and/or should DITypeRef be implicitly convertible from a DIType?


http://reviews.llvm.org/D19236





More information about the llvm-commits mailing list