[PATCH] D15922: [Cloning] rename cloneLoopWithPreheader() and add assert to ensure no sub-loops
Hal Finkel via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 12:45:28 PDT 2016
hfinkel added a comment.
In http://reviews.llvm.org/D15922#404195, @anemet wrote:
> In http://reviews.llvm.org/D15922#403741, @ashutosh.nema wrote:
>
> > Thanks Vaivaswatha, looks OK to me except the name of function.
> > As I mentioned earlier ‘cloneInnermostLoopWithPreheader’ looks more intuitive
> > vs ‘cloneInnerLoopWithPreheader’ because we clone the innermost loop only.
> >
> > Adam, Hal:
> > What’s your opinion on this name change ?
>
>
> Sounds good to me.
Me too.
http://reviews.llvm.org/D15922
More information about the llvm-commits
mailing list