[PATCH] D19098: [AArch64] [ARM] Make a target-independent llvm.thread.pointer intrinsic.

[Ahmed Bougacha via llvm-commits]

ab accepted this revision.
ab added a reviewer: ab.
ab added a comment.
This revision is now accepted and ready to land.

LGTM with a couple extra nits, thanks!


================
Comment at: test/Assembler/thread-pointer.ll:1
@@ +1,2 @@
+; Test autoupgrade of arch-specific thread pointer intrinsics
+; RUN: llvm-as < %s | llvm-dis | FileCheck %s
----------------
Rename the file to something like autoupgrade-thread-pointer.ll ?

================
Comment at: test/Assembler/thread-pointer.ll:10
@@ +9,3 @@
+; CHECK: call i8* @llvm.thread.pointer()
+  %1 = tail call i8* @llvm.aarch64.thread.pointer()
+  ret i8 *%1
----------------
-tail

================
Comment at: test/CodeGen/AArch64/arm64-builtins-linux.ll:14-19
@@ -9,3 +13,7 @@
+
+define i8* @thread_pointer2() {
+; CHECK: thread_pointer2:
+; CHECK: mrs {{x[0-9]+}}, TPIDR_EL0
   %1 = tail call i8* @llvm.aarch64.thread.pointer()
   ret i8* %1
 }
----------------
I think you can remove the codegen tests with the old intrinsics now.


Repository:
  rL LLVM

http://reviews.llvm.org/D19098