[PATCH] D19190: [ELF] - Implemented PROVIDE linker script command.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 11:41:10 PDT 2016


ruiu added inline comments.

================
Comment at: ELF/LinkerScript.cpp:170-176
@@ -159,1 +169,9 @@
 
+std::vector<StringRef> LinkerScript::getProvides() {
+  std::vector<StringRef> Provides;
+  for (LocationNode &Node : Locations)
+    if (Node.Type == Command::Provide)
+      Provides.push_back(Node.Name);
+  return Provides;
+}
+
----------------
I'd make the symbol table visible from the linker script in order to eliminate this plumbing between LinkerScript and Writer.


http://reviews.llvm.org/D19190





More information about the llvm-commits mailing list