[PATCH] D19172: New optimization bisect implementation (now modeled on optnone handling)

Andy Kaylor via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 09:30:44 PDT 2016


andrew.w.kaylor added inline comments.

================
Comment at: lib/Passes/PassBuilder.cpp:70-71
@@ +69,4 @@
+  PreservedAnalyses run(Module &M) {
+    // This call is here for testing purposes.
+    skipPassForModule(name(), M);
+    return PreservedAnalyses::all();
----------------
MatzeB wrote:
> I don't understand this, accidental commit? Same for the following changes.
There's nothing being done here, so skipping and not skipping are functionally equivalent.  I'm using the NoOpXXX classes to test the new pass manager interface.  If that isn't their intent, I can try something else.  If it is, I'll clarify the comment.


Repository:
  rL LLVM

http://reviews.llvm.org/D19172





More information about the llvm-commits mailing list