[PATCH] D19203: AMDGPU/SI: Add llvm.amdgcn.s.waitcnt.all intrinsic

[Matt Arsenault via llvm-commits]

arsenm added inline comments.

================
Comment at: include/llvm/IR/IntrinsicsAMDGPU.td:71
@@ -70,1 +70,3 @@
 
+def int_amdgcn_s_waitcnt_all : Intrinsic<[], [], [IntrConvergent]>;
+
----------------
tstellarAMD wrote:
> I think the intrinsic should be int_amdgpu_s_waitcnt, and we should expose the configuration bits with an input argument.
I'm not sure waitcnt should be directly exposed, and it should probably be a memfence intrinsic. However, I'm not clear if what is really wanted here is the cache flush intrinsics like is necessary for OpenCL 2.0

This also doesn't need to be convergent


http://reviews.llvm.org/D19203