[PATCH] D18701: [ARM] Adding IEEE-754 SIMD detection to loop vectorizer

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 03:17:03 PDT 2016


rengolin added inline comments.

================
Comment at: lib/Target/ARM/ARMTargetTransformInfo.h:58
@@ +57,3 @@
+  bool enablePotentiallyUnsafeFPVectorization() {
+    return ST->hasFPARMv8() || ST->isTargetDarwin();
+  }
----------------
jgreenhalgh wrote:
> What's the idea here? The FTZ behaviour doesn't change in AArch32 execution state on ARMv8-A, you're still unsafe. The full IEEE-compliant Advanced SIMD is in AArch64 execution state.
Hum. I've been wrongly advised on this one... Now reading the ARM ARM, I can see that this is the case. I'll change it to match AArch64 only. Thanks!


http://reviews.llvm.org/D18701





More information about the llvm-commits mailing list