[PATCH] D19164: [mips][ias] Stream macro expansions to output instead of buffering them. NFC.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 18 01:49:55 PDT 2016


dsanders added a comment.

Thanks


================
Comment at: lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp:814-817
@@ -816,4 +813,6 @@
 
+#if 0
   for (const MCInst &Inst : StoreInsts)
     getStreamer().EmitInstruction(Inst, STI);
+#endif
 }
----------------
vkalintiris wrote:
> Did you intend to leave this wrapped in preprocessor's if/endif?
No, I'll remove it for the commit.

I'll also leave a fixme comment which should clarify why I left the seemingly-redundant if-statement in.


http://reviews.llvm.org/D19164





More information about the llvm-commits mailing list