[PATCH] D19195: [Clang][AVX512][BuiltIn] Adding suppot to builtin for VPERMD and VPERMW instruction set

[Asaf Badouh via llvm-commits]

AsafBadouh added inline comments.

================
Comment at: lib/Headers/avx512bwintrin.h:2065
@@ +2064,3 @@
+                 (__v32hi) __A,
+                 (__v32hi) _mm512_setzero_hi (),
+                 (__mmask32) -1);
----------------
can you use _mm512_undefined_epi32() ?


================
Comment at: lib/Headers/avx512vbmiintrin.h:87
@@ +86,3 @@
+                 (__v64qi) __A,
+                 (__v64qi) _mm512_setzero_si512 (),
+                 (__mmask64) -1);
----------------
can you use _mm512_undefined_epi32() ?


================
Comment at: lib/Headers/avx512vlbwintrin.h:3180
@@ +3179,3 @@
+                 (__v8hi) __A,
+                 (__v8hi) _mm_setzero_hi (),
+                 (__mmask8) -1);
----------------
_mm_undefined_si128() will work here?

================
Comment at: lib/Headers/avx512vlbwintrin.h:3208
@@ +3207,3 @@
+                 (__v16hi) __A,
+                 (__v16hi) _mm256_setzero_si256 (),
+                 (__mmask16) -1);
----------------
_mm256_undefined_si256()

================
Comment at: lib/Headers/avx512vlintrin.h:7803
@@ +7802,3 @@
+                 ( __I),\
+                 (__v4di) _mm256_setzero_si256 (),\
+                 (__mmask8) -1);\
----------------
_mm256_undefined_si256()

================
Comment at: lib/Headers/avx512vlintrin.h:7812
@@ +7811,3 @@
+                 (__v4di) __X,
+                 (__v4df) _mm256_setzero_pd (),
+                 (__mmask8) -1);
----------------
_mm256_undefined_si256()

================
Comment at: lib/Headers/avx512vlintrin.h:7849
@@ +7848,3 @@
+                 (__v4di) __X,
+                 (__v4di) _mm256_setzero_si256 (),
+                 (__mmask8) -1);
----------------
_mm256_undefined_si256()

================
Comment at: lib/Headers/avx512vlintrin.h:7887
@@ +7886,3 @@
+                (__v8si) __X,
+                (__v8sf) _mm256_setzero_ps (),
+                (__mmask8) -1);
----------------
_mm256_undefined_si256()

================
Comment at: lib/Headers/avx512vlintrin.h:7915
@@ +7914,3 @@
+                 (__v8si) __X,
+                 (__v8si) _mm256_setzero_si256,
+                 (__mmask8) -1);
----------------
_mm256_undefined_si256()


http://reviews.llvm.org/D19195