[PATCH] D18126: Port InstrProfiling pass to new pass manager
Chandler Carruth via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 18 00:30:00 PDT 2016
chandlerc added a comment.
In http://reviews.llvm.org/D18126#396423, @davidxl wrote:
> Addressed Chandler's review comments.
>
> Note that the creator API name for the legacy pass remains unchanged -- this is to avoid updating Clang. If changing the name is preferred (i.e. adding 'Legacy' in it), it will be done as a follow up.
Forgot to address this: please feel free to update the API name in this patch, and immediately land a patch to Clang that follows that API update. We routinely do cross-LLVM-project API updates. Just make sure you find the users in Clang or Polly or wherever. It can be very helpful to build and test the updates ahead of time so you can land the patches back to back with a very short delay. The build bots try to wait a few seconds to pick up patches landed in this fashion and avoid spurious failures.
http://reviews.llvm.org/D18126
More information about the llvm-commits
mailing list