[PATCH] D19167: [esan] EfficiencySanitizer instrumentation pass
Derek Bruening via llvm-commits
llvm-commits at lists.llvm.org
Sat Apr 16 07:05:21 PDT 2016
bruening added inline comments.
================
Comment at: lib/Transforms/Instrumentation/EfficiencySanitizer.cpp:156
@@ +155,3 @@
+ MemmoveFn = checkSanitizerInterfaceFunction(
+ M.getOrInsertFunction("memmove", IRB.getInt8PtrTy(), IRB.getInt8PtrTy(),
+ IRB.getInt8PtrTy(), IntptrTy, nullptr));
----------------
aizatsky wrote:
> bruening wrote:
> > aizatsky wrote:
> > > why not __esan_memmove?
> > That would be more consistent. This current code is modeled after what ThreadSanitizer.cpp and AddressSanitizer.cpp do: they have __xsan_* for the others but just "mem*" for the intrinsics. I am happy to add __esan_.
> I'm not sure if there was a reason for that. Maybe history. If nothing prevents it, I suggest you use __esan_ prefix everywhere. Would be much easier to spot/understand the assemby dump.
These are calling the libc functions, which are then intercepted, rather than calling custom routines in the runtime: thus they must remain the exported libc names.
http://reviews.llvm.org/D19167
More information about the llvm-commits
mailing list