[PATCH] D18494: ThinLTO: add module caching handling.

[Teresa Johnson via llvm-commits]

tejohnson added inline comments.

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:183
@@ -178,3 +182,3 @@
     StringRef ModuleIdentifier,
-    DenseMap<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR) {
+    std::map<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR) {
   // We won't optimize the globals that are referenced by an alias for now
----------------
joker.eph wrote:
> tejohnson wrote:
> > Why this change? D18908 uses a DenseMap.
> To compute the hash for the cache, we iterate over the map, so we need a stable ordering.
Ah, ok. Probably worth a comment.


http://reviews.llvm.org/D18494