[PATCH] D18494: ThinLTO: add module caching handling.

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Couple small comments, but otherwise, I think this looks good.


================
Comment at: include/llvm/ADT/StringExtras.h:62
@@ -61,1 +61,3 @@
 
+// Convert buffer \p Input to its hexadecimal representation.
+// The returned string is double the size of \p Input.
----------------
Use doxygen style comment "///"

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:183
@@ -178,3 +182,3 @@
     StringRef ModuleIdentifier,
-    DenseMap<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR) {
+    std::map<GlobalValue::GUID, GlobalValue::LinkageTypes> &ResolvedODR) {
   // We won't optimize the globals that are referenced by an alias for now
----------------
Why this change? D18908 uses a DenseMap.


http://reviews.llvm.org/D18494