[PATCH] D18619: [AArch64] Combine callee-save and local stack SP adjustment instructions.

[Renato Golin via llvm-commits]

rengolin added inline comments.

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:695
@@ -674,2 +694,3 @@
 
+  assert(!(UseFP && ForceSP) && "ForceSP flag could not be honored");
   assert((isFixed || !RegInfo->needsStackRealignment(MF) || !UseFP) &&
----------------
Right, than maybe moving the assert inside "if (isFixed)" would guide people when it does hit?

================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:823-824
@@ -800,12 +822,4 @@
       ++i;
   }
-
-  // Align first offset to even 16-byte boundary to avoid additional SP
-  // adjustment instructions.
-  // Last pair offset is size of whole callee-save region for SP
-  // pre-dec/post-inc.
-  RegPairInfo &LastPair = RegPairs.back();
-  assert(AFI->getCalleeSavedStackSize() % 8 == 0);
-  LastPair.Offset = AFI->getCalleeSavedStackSize() / 8;
 }
 
----------------
Indeed.


http://reviews.llvm.org/D18619