[PATCH] D19159: [sanitizer] [SystemZ] Implement internal_clone.

[Marcin Kościelnicki via llvm-commits]

koriakin added a comment.

In http://reviews.llvm.org/D19159#402783, @kcc wrote:

> Ok. We already have files with suffix aarch64 or aarch64.
>  Please try to follow this rule: do not add any new #ifdef unless
>
> 1. the ifdef is a single top-level ifdef in a separate file
> 2. you are adding an #elif to an already existing #ifdef/#elif sequence.


Well, technically the outer #elif in this patch does follow the rule (the inner ones don't, but they're much better justified).

Anyhow, here's the plan:

1. Revert the AvoidCVE... patch (it's not doing much good without ASan/MSan/TSan support anyhow).
2. Submit a patch creating sanitizer_linux_s390.cc and moving internal_mmap there.
3. Resubmit this patch with a dep on #2.
4. Resubmit AvoidCVE... patch with empty AvoidCVE...() in common code and with a dep on #2.

I have one more patch in queue that adds s390-specific code which will end up in sanitizer_linux_s390.cc, but it's going to be a while before I get all dependencies  merged.


Repository:
  rL LLVM

http://reviews.llvm.org/D19159