[PATCH] D19135: [sanitizers] Teach the internal demangler about Swift names

[Kostya Serebryany via llvm-commits]

kcc added a subscriber: kcc.
kcc added reviewers: aizatsky, vitalybuka.
kcc added a comment.

Anna, 
Sadly, Alexey has left our team (he may still want to comment, but I wouldn't count on it). 
I'll let Mike review this further.


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_posix_libcdep.cc:77
@@ +76,3 @@
+  swift_demangle_ft swift_demangle_f =
+    (swift_demangle_ft) dlsym(RTLD_DEFAULT, "swift_demangle");
+  if (swift_demangle_f)
----------------
does this mean that we call dlsym every time we are trying to demangle something? 

================
Comment at: lib/sanitizer_common/tests/sanitizer_symbolizer_test.cc:59
@@ +58,3 @@
+TEST(Symbolizer, DemangleCXXAndSwift) {
+  // The Swift name will only be demangled if the Swift runtime is linked in.
+  EXPECT_STREQ("_TtSd", DemangleCXXAndSwift("_TtSd"));
----------------
So, is a swift-specific test possible? 


http://reviews.llvm.org/D19135