[PATCH] D18836: Make aliases explicit in the module summary

[Teresa Johnson via llvm-commits]

tejohnson accepted this revision.
tejohnson added a comment.
This revision is now accepted and ready to land.

Thanks! One unaddressed nit noted below, and a suggestion for future patch.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:5939
@@ +5938,3 @@
+    // FS_COMBINED_ALIAS: [modid, linkage, offset]
+    // Aliases must be emitted (and parsed) after all FS_PERMODULE entries, as
+    // they expect all aliasee summaries to be available.
----------------
This one still needs a fix.

================
Comment at: test/Bitcode/thinlto-function-summary.ll:1
@@ -1,2 +1,2 @@
-; RUN: opt -module-summary < %s | llvm-bcanalyzer -dump | FileCheck %s -check-prefix=BC
+; RUN: opt -name-anon-functions -module-summary < %s | llvm-bcanalyzer -dump | FileCheck %s -check-prefix=BC
 ; Check for summary block/records.
----------------
Not for this patch, but I still think it would be useful to make opt either force enable -name-anon-functions when -module-summary is supplied, or at least warn if it wasn't.


http://reviews.llvm.org/D18836