[PATCH] D19107: [ELF] - Tweak sorting rules for output sections to place orphan sections at end.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:68
@@ -67,3 +67,3 @@
 // to use the default rule which is implemented in Writer.cpp.
 int LinkerScript::compareSections(StringRef A, StringRef B) {
   auto E = SectionOrder.end();
----------------
ruiu wrote:
> grimar wrote:
> > Forgot to change the comment.
> > I think it can be:
> > 
> > ```
> > // A compartor to sort output sections. Returns -1 or 1 if 
> > // A or B are mentioned in linker script. Otherwise, returns 0
> > // to use the default rule which is implemented in Writer.cpp.
> > ```
> Why don't you update the comment?
Done. I assumed it is acceptable to update it during next iteration (which almost always happens) or before commit if "LGTM" is given.


http://reviews.llvm.org/D19107