[PATCH] D19139: [LTO] SplitCodeGen new API

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 16:29:14 PDT 2016


joker.eph added inline comments.

================
Comment at: include/llvm/CodeGen/ParallelCG.h:49
@@ +48,3 @@
+             ArrayRef<llvm::raw_pwrite_stream *> BCOSs,
+             std::function<std::unique_ptr<TargetMachine>()> F,
+             TargetMachine::CodeGenFileType FT = TargetMachine::CGFT_ObjectFile,
----------------
joker.eph wrote:
> Is there a better name for  F? 
> Also can you add a doxygen for this API (you can refer to the other saying this is a variant that takes a factory function for the TargetMachine)
Also: `const &`


Repository:
  rL LLVM

http://reviews.llvm.org/D19139





More information about the llvm-commits mailing list