[PATCH] D19112: [asan] [SystemZ] Add slop for stack address detection.

[Evgeniy Stepanov via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM w/ a nit


================
Comment at: lib/asan/asan_posix.cc:49
@@ +48,3 @@
+  // page granularity.
+  bool IsStackAccess = sig.addr >= (sig.sp & ~0xFFF) &&
+                       sig.addr < sig.sp + 0xFFFF;
----------------
Do you mean that sig.addr is rounded down to the nearest page boundary?
Do you need some extra space below sp (same as +512 in the common case below)? I.e. is it possible that the true fault address is below sp and falls into a different page, and then sig.addr would be ((sig.sp & 0xFFF) - 0x1000) ?



Repository:
  rL LLVM

http://reviews.llvm.org/D19112