[PATCH] D19125: Enable __float128 on X86_64

[Bruno Cardoso Lopes via llvm-commits]

bruno added a comment.

I agree with H.J Lu.

Looks like test/CodeGenCXX/float128-declarations.cpp deserves some x86 RUN lines too.

Some comments inline.


================
Comment at: lib/Basic/Targets.cpp:4176
@@ -4173,1 +4175,3 @@
+  }
+
   bool validateGlobalRegisterVariable(StringRef RegName,
----------------
clang-format this one, looks like it could be a onliner like the other aboves, also place it below hasInt128Type().

================
Comment at: test/Sema/128bitfloat.cpp:4
@@ -3,1 +3,3 @@
 
+#ifdef __x86_64__
+__float128 f;
----------------
Better to have a x86-128bitfloat.cpp file instead, targetting i386/x86_64 with two different RUN lines.  This ensures this feature gets tested when host isn't x86.


Repository:
  rL LLVM

http://reviews.llvm.org/D19125