[PATCH] D19080: allow SSAUpdater to be used for Swift

[Mehdi AMINI via llvm-commits]

joker.eph added inline comments.

================
Comment at: lib/CodeGen/MachineSSAUpdater.cpp:252
@@ +251,3 @@
+  static PhiItT PhiItT_begin(BlkT *BB) { return BB->begin(); }
+  static PhiItT PhiItT_end(BlkT *BB) { return BB->end(); }
+
----------------
aschwaighofer wrote:
> joker.eph wrote:
> > The interface is somehow lying: `PhiItT_end` is not the end of the PHIs list.
> > (not that I have a great suggestion to solve that)
> How about calling it PhiCandidateItT?
At least it wouldn't be a lie :)

I wonder if it would be useful to have real Phi iterator in LLVM though?


http://reviews.llvm.org/D19080