[PATCH] D18758: [Coverage] Support for making test data for more than one function.

David Li via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 10:16:18 PDT 2016


davidxl added a comment.

nice cleanup!


================
Comment at: llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp:85
@@ +84,3 @@
+struct InputFunctionCoverageData {
+  // Maps an global file index from CoverageMappingTest.Files
+  // to the index of that file within this function.
----------------
an --> the 

================
Comment at: llvm/trunk/unittests/ProfileData/CoverageMappingTest.cpp:87
@@ +86,3 @@
+  // to the index of that file within this function.
+  SmallDenseMap<unsigned, unsigned> ReverseVirtualFileMapping;
+  std::string Name;
----------------
Is this mapping strictly needed? Can global file index be used without creating function level file index?


http://reviews.llvm.org/D18758





More information about the llvm-commits mailing list