[PATCH] D19109: [ELF] - Refactoring of end/edata/etext implementation.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 09:53:55 PDT 2016


grimar added a comment.

In http://reviews.llvm.org/D19109#401395, @ruiu wrote:

> I probably wouldn't do that because it doesn't seem to be worth to create a new type. If you don't like the repetition of `if (...) ... = Val;`, then how about defining a helper lambda for assignment like this?
>
>   auto Set = [&](DefinedRegular<ELFT> *S, uint64_t V) { If (S) S->Value = V; }


I would prefer mine version, I dont like not only repetitions of assignments, but also additional variables declarations. 
And that's not real type, just typedef for pair, so I dont find this to excessive.

But returning to subject - since that was already committed, do you think this should be reverted ?


Repository:
  rL LLVM

http://reviews.llvm.org/D19109





More information about the llvm-commits mailing list