[PATCH] D19109: [ELF] - Refactoring of end/edata/etext implementation.
Rafael Ávila de Espíndola via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 14 06:59:09 PDT 2016
rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.
LGTM with nits.
================
Comment at: ELF/Symbols.h:393
@@ -392,1 +392,3 @@
template <class ELFT> struct ElfSym {
+ typedef std::pair<DefinedRegular<ELFT> *, DefinedRegular<ELFT> *> LinkerSym;
+
----------------
SymPair maybe?
================
Comment at: ELF/Writer.cpp:1665
@@ -1665,1 +1664,3 @@
// _end is the first location after the uninitialized data region.
+ auto Assign = [](ElfSym<ELFT>::LinkerSym &Sym, uintX_t Val) {
+ if (Sym.first)
----------------
This can be a static function, no need to make it a lambda.
http://reviews.llvm.org/D19109
More information about the llvm-commits
mailing list