[PATCH] D19107: [ELF] - Tweak sorting rules for output sections to place orphan sections at end.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 14 05:30:13 PDT 2016


grimar added inline comments.

================
Comment at: ELF/LinkerScript.cpp:68
@@ -67,3 +67,3 @@
 // to use the default rule which is implemented in Writer.cpp.
 int LinkerScript::compareSections(StringRef A, StringRef B) {
   auto E = SectionOrder.end();
----------------
Forgot to change the comment.
I think it can be:

```
// A compartor to sort output sections. Returns -1 or 1 if 
// A or B are mentioned in linker script. Otherwise, returns 0
// to use the default rule which is implemented in Writer.cpp.
```


http://reviews.llvm.org/D19107





More information about the llvm-commits mailing list