[PATCH] D18987: Add SVN version to libLLVMLTO

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

Thanks, updated. I'll commit later.


================
Comment at: cmake/modules/VersionFromVCS.cmake:5
@@ -4,3 +4,3 @@
 
-function(add_version_info_from_vcs VERS)
+function(add_version_info_from_vcs VERS SOURCE_DIR)
   string(REPLACE "svn" "" result "${${VERS}}")
----------------
beanz wrote:
> I assume you'll also have a corresponding clang patch to update the caller there, correct? Alternatively you could have the source_dir be an optional parameter and have it fall back to CMAKE_CURRENT_SOURCE_DIR if ARGN == 0.
Let's go for the optional parameter!


http://reviews.llvm.org/D18987