[PATCH] D18792: [SCEV][LAA] Add tests for SCEV expression transformations performed during LAA

[Sanjoy Das via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

lgtm with minor stylistic comments


================
Comment at: lib/Analysis/ScalarEvolution.cpp:10227
@@ +10226,3 @@
+  // For each block.
+  for (Loop::block_iterator bb = L.block_begin(),
+       be = L.block_end(); bb != be; ++bb)
----------------
Can you use a range for here?

================
Comment at: lib/Analysis/ScalarEvolution.cpp:10230
@@ +10229,3 @@
+
+    for (BasicBlock::iterator it = (*bb)->begin(), e = (*bb)->end();
+         it != e; ++it) {
----------------
Same here: why not use a range for loop here?


http://reviews.llvm.org/D18792