[PATCH] D19094: Nuke getGlobalContext() from LLVM (but the C API)

Amaury SECHET via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 13 22:26:26 PDT 2016


deadalnix added a subscriber: deadalnix.
deadalnix added a comment.

Red diffs are the best diffs.


================
Comment at: lib/Target/Target.cpp:16
@@ -15,2 +15,3 @@
 #include "llvm-c/Target.h"
+#include "llvm-c/Core.h"
 #include "llvm-c/Initialization.h"
----------------
This tends to be a compile time disaster. Can you add a comment that it is for the global context and that we want to kill it eventually ?

Maybe you could declare the function locally instead of importing the whole Core.h thing ?


http://reviews.llvm.org/D19094





More information about the llvm-commits mailing list