[PATCH] D18867: [IndVarSimplify] Eliminate zext of a signed IV when the IV is known to be non-negative

[Philip Reames via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

Test case?  Mandatory.

Drive by comments.  I'll defer actual review to Sanjoy or someone more comfortable with this code.  If you haven't gotten a review within a reasonable time frame (1 week), feel free to ping me directly and I'll take another look and rebuild my mental model of this code to be able to review..


================
Comment at: lib/Transforms/Scalar/IndVarSimplify.cpp:1402
@@ -1400,1 +1401,3 @@
+                           SE->getConstant(NarrowSCEV->getType(), 0)) ||
+      isKnownNonNegative(NarrowDef, NarrowDef->getModule()->getDataLayout(), 0);
   for (User *U : NarrowDef->users()) {
----------------
Remove explicit value of default param.


http://reviews.llvm.org/D18867