[PATCH] D19077: AMDGPU: Add skeleton GlobalIsel implementation

[Quentin Colombet via llvm-commits]

qcolombet added a comment.

Hi Tom,

Mostly LGTM, but I do not see AMDGPUGISelAccessor.h in the diff.

Cheers,
-Quentin


================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.h:29-30
@@ +28,4 @@
+  bool LowerReturn(MachineIRBuilder &MIRBuiler, const Value *Val,
+                   unsigned VReg) const override;
+  bool
+  LowerFormalArguments(MachineIRBuilder &MIRBuilder,
----------------
By all means, fix that in the base class :).


http://reviews.llvm.org/D19077