[PATCH] D18827: Rework/enhance stack coloring data flow analysis.

[Wei Mi via llvm-commits]

wmi added a comment.

Some Nits. Other than that LGTM. Quentin knows it better than me so I will let him to approve it finally.

Thanks,
Wei.


================
Comment at: lib/CodeGen/StackColoring.cpp:366
@@ +365,3 @@
+        if (!isStart) {
+          assert(slots.size() == 1);
+          int Slot = slots[0];
----------------
Missing an assert message.

================
Comment at: lib/CodeGen/StackColoring.cpp:822
@@ -720,2 +821,3 @@
   calculateLiveIntervals(NumSlots);
+  // DEBUG(dumpIntervals());
 
----------------
We want dumpIntervals() after intervals being computed.


http://reviews.llvm.org/D18827