[PATCH] D19077: AMDGPU: Add skeleton GlobalIsel implementation

[Tom Stellard via llvm-commits]

tstellarAMD marked 3 inline comments as done.

================
Comment at: lib/Target/AMDGPU/AMDGPUCallLowering.h:28-29
@@ +27,4 @@
+
+  bool LowerReturn(MachineIRBuilder &MIRBuiler, const Value *Val,
+                   unsigned VReg) const override;
+  bool
----------------
arsenm wrote:
> Should probably update these to use the current start with lowercase naming convention while it's new
Ok, I can try to fix up the parent in a new class.

================
Comment at: lib/Target/AMDGPU/AMDGPUSubtarget.h:112
@@ -109,1 +111,3 @@
 
+  /// This object will take onwership of \p GISelAccessor.
+  void setGISelAccessor(AMDGPUGISelAccessor &GISelAccessor) {
----------------
arsenm wrote:
> Typo onwership, although it seems like this comment would only go on the base class
I dropped this comment.


http://reviews.llvm.org/D19077