[PATCH] D19037: [llvm-c] Add the ability to create debug locations

[Amaury SECHET via llvm-commits]

deadalnix requested changes to this revision.
deadalnix added a comment.
This revision now requires changes to proceed.

Various things here :

- Typically, there is a LOT of DILoc generated in any non toy module. Wrapping them all in a Value is going to be VERY wasteful. I would vote to add a LLVMMetadataRef type and use it.
- There is no need to create a new C test for that IMO. The echo test should be extended and a module with lcoation information should be fed to it.
- How is the scope created using that API ? If the plan is to use the old way to scope instead of DIScope, then I'm not sure where this is going. This allow to mix the old debug API with the new one, while not being able to get the largest benefit in the name a reduced resource requirement.

On a side note I have a patch that wrap the whole DIBuilder thing in the C API, that i did not submitted yet as testing was lacking.


http://reviews.llvm.org/D19037