[PATCH] D19015: [LTO] ensure lto_codegen_debug_options() are passed on to LLVM

[Robinson, Paul via llvm-commits]

> -----Original Message-----
> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On Behalf
> Of Rafael Espíndola via llvm-commits
> Sent: Wednesday, April 13, 2016 8:39 AM
> To: reviews+D19015+public+3b72f3e9e30a204c at reviews.llvm.org
> Cc: llvm-commits
> Subject: Re: [PATCH] D19015: [LTO] ensure lto_codegen_debug_options() are
> passed on to LLVM
> 
> On 13 April 2016 at 11:33, Paul Robinson
> <Paul_Robinson at playstation.sony.com> wrote:
> > probinson added a subscriber: probinson.
> > probinson added a comment.
> >
> > In http://reviews.llvm.org/D19015#399467, @joker.eph wrote:
> >
> >> In http://reviews.llvm.org/D19015#399466, @thomasguest wrote:
> >>
> >> > In http://reviews.llvm.org/D19015#399462, @joker.eph wrote:
> >> >
> >> > > To put it differently: there is no command line option for LLVM (as
> a library), only APIs.
> >> >
> >> >
> >> > Yes, what I am really after is a way to configure codegen when using
> LLVM via the LTO library. At the moment I cannot do so.
> >>
> >>
> >> Yes, apparently no-one had this need till now, submit a patch :)
> >
> >
> > Let me point out that the gold plugin works exactly this way (pass in cl
> options as a string).
> > It might not be ideal but it's what we have today.
> > LLVM-as-library doesn't really have another way to conjure up
> TargetOptions (I *think* clang creates one directly, sorry can't check
> right now, but that seems even more fragile).
> 
> 
> No. In gold ParseCommandLineOptions is passed only options the user
> itself passed to the plugin. So the gold plugin implements a debug
> option with another.

This sounds like you are arguing that the entire content of 
llvm::TargetOptions are debugging parameters?  I disagree, but then
I'm probably not fully understanding your argument.
--paulr

> 
> 
> Cheers,
> Rafael
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits