[PATCH] D18959: [lld] Implement --dynamic-list

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a few nits. Thanks!


================
Comment at: ELF/DynamicList.cpp:16-23
@@ +15,10 @@
+
+#include "DynamicList.h"
+#include "Config.h"
+#include "Driver.h"
+#include "ScriptParser.h"
+#include "llvm/Support/FileSystem.h"
+#include "llvm/Support/MemoryBuffer.h"
+#include "llvm/Support/Path.h"
+#include "llvm/Support/StringSaver.h"
+
----------------
Do you need Driver.h, FileSystem.h, Path.h and StringSaver.h?

================
Comment at: ELF/DynamicList.h:14
@@ +13,3 @@
+#include "lld/Core/LLVM.h"
+#include "llvm/ADT/StringSet.h"
+#include "llvm/Support/MemoryBuffer.h"
----------------
You can remove StringSet.h no?

================
Comment at: ELF/Options.td:48
@@ +47,3 @@
+def dynamic_list : Separate<["--", "-"], "dynamic-list">,
+  HelpText<"Dynamic list to use">;
+
----------------
Let's use the same help message as gold. `Read a list of dynamic symbols`


http://reviews.llvm.org/D18959