[PATCH] D18999: [ELF/LTO] Parallel Codegen for LLD

[Davide Italiano via llvm-commits]

davide added inline comments.

================
Comment at: ELF/Options.td:237-238
@@ -237,1 +236,4 @@
+// LTO-related options.
+def jobs : Joined<["--"], "jobs=">,
+  HelpText<"Number of threads to run codegen">;
 def disable_verify : Flag<["-"], "disable-verify">;
----------------
pcc wrote:
> ruiu wrote:
> > I prefer --thread-count because gold has that option.
> Gold's `--thread-count` does not affect LTO. Furthermore, parallel LTO codegen can result in the linker producing different binaries based on the number of threads, and users of `--thread-count` probably wouldn't expect that option to change the binary. I think this should probably be something prefixed with `--lto-`.
That option has a different semantic. -jobs is what the plugin uses.
If you prefer another name, I'm all for it, but I wouldn't clash.


================
Comment at: ELF/SymbolTable.cpp:117
@@ +116,3 @@
+
+    // Replace bitcode symbols.
+    llvm::DenseSet<StringRef> DummyGroups;
----------------
ruiu wrote:
> Move this code before the enclosing for-loop. (Because the entire for-loop is to replace bitcode symbols.)
Which code in particular? 


http://reviews.llvm.org/D18999